Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: remove increased target size for scroll thumbs #4650

Merged
merged 1 commit into from
Dec 24, 2024
Merged

chore: remove increased target size for scroll thumbs #4650

merged 1 commit into from
Dec 24, 2024

Conversation

kof
Copy link
Member

@kof kof commented Dec 24, 2024 •
edited
Loading

Because we don't have enough space and touch device user scrolls the entire area directly anyways

Description

  1. What is this PR about (link the issue and add a short description)

Steps for reproduction

  1. click button
  2. expect xyz

Code Review

  • hi @kof, I need you to do
    • conceptual review (architecture, feature-correctness)
    • detailed review (read every line)
    • test it on preview

Before requesting a review

  • made a self-review
  • added inline comments where things may be not obvious (the "why", not "what")

Before merging

  • tested locally and on preview environment (preview dev login: 0000)
  • updated test cases document
  • added tests
  • if any new env variables are added, added them to .env file

@kof
remove increased target size for scrollers because we don't have enou…
9c1cd7b 
…gh space and mobile touch is not a priority here, touch scrolls the area directly anyways
@kof kof requested review from TrySound and johnsicili December 24, 2024 19:11
johnsicili
johnsicili approved these changes Dec 24, 2024
View reviewed changes
Copy link
Contributor

@johnsicili johnsicili left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice

@kof kof changed the title chore: remove increased target size for scrollers chore: remove increased target size for scroll thumbs Dec 24, 2024
@kof kof merged commit 721c5a8 into main Dec 24, 2024
19 checks passed
@kof kof deleted the scrollbar branch December 24, 2024 19:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@johnsicili johnsicili johnsicili approved these changes

@TrySound TrySound TrySound approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kof @TrySound @johnsicili